Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Initial Skaffolding #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Initial Skaffolding #2

wants to merge 5 commits into from

Conversation

elie-h
Copy link
Collaborator

@elie-h elie-h commented Jun 9, 2020

No description provided.

@o7n
Copy link
Collaborator

o7n commented Jun 9, 2020

I'm not sure if you should be checking in config files that contain your local paths.
They seem to be very specific to your exact build env.

@elie-h
Copy link
Collaborator Author

elie-h commented Jun 9, 2020

I'm not sure if you should be checking in config files that contain your local paths.
They seem to be very specific to your exact build env.

Yep, forgot to add an ignore for my vscode config
Fixed now

@o7n
Copy link
Collaborator

o7n commented Jun 9, 2020

Shouldn't we be calling this library twintng in order to avoid all kinds of conflicts?
i.e. have a src/twintng ?

@elie-h
Copy link
Collaborator Author

elie-h commented Jun 9, 2020

Shouldn't we be calling this library twintng in order to avoid all kinds of conflicts?
i.e. have a src/twintng ?

Yeah good shout - updated

@o7n
Copy link
Collaborator

o7n commented Jun 10, 2020

I have added basic working scraper functionality:

  • getFollowers (including generator)
  • getFollowing (including generator)
  • getProfile
  • runSearch (work in progress)

Next steps are:

  • parsing tweet HTML and putting them in a dict
  • creating generator for search
  • creating different output methods
  • converting config params to a search query
  • creating command line tool
  • (making sure the code passes linting checks)

I can spend more time on this after the weekend.
In the meanwhile, all contributions on the next steps are welcome!

@elie-h
Copy link
Collaborator Author

elie-h commented Jun 11, 2020

I have added basic working scraper functionality:

  • getFollowers (including generator)
  • getFollowing (including generator)
  • getProfile
  • runSearch (work in progress)

Next steps are:

  • parsing tweet HTML and putting them in a dict
  • creating generator for search
  • creating different output methods
  • converting config params to a search query
  • creating command line tool
  • (making sure the code passes linting checks)

I can spend more time on this after the weekend.
In the meanwhile, all contributions on the next steps are welcome!

Changes look good
I will reduce some of the checks on linting to get it passing

@pielco11
Copy link
Member

I'll handle the tweet HTML thing during the weekend

@pielco11
Copy link
Member

Hi guys

as you may see, I haven't pushed yet. I hope to get something working by the next weekend.

@o7n
Copy link
Collaborator

o7n commented Jul 13, 2020

@pielco11 @eh-93 are you still interested in pursuing this?

@pielco11
Copy link
Member

Honestly, I do hardly find the time

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants